[PATCH] blkparse_fmt: use memcmp() it is (usually) faster

At least it has better worst case performance.

diff --git a/blkparse_fmt.c b/blkparse_fmt.c
index 8031a8e661bba91bdabec497a4ba24dace9fe594..34b920b2256de9caf6250444f08fc10c780edcf7 100644 (file)
--- a/blkparse_fmt.c
+++ b/blkparse_fmt.c
@@ -79,14 +79,11 @@ static inline void fill_rwbs(char *rwbs, struct blk_io_trace *t)
        rwbs[i] = '\0';
 }
 
-static int pdu_rest_is_zero(unsigned char *pdu, int len)
+static inline int pdu_rest_is_zero(unsigned char *pdu, int len)
 {
-       int i = 0;
-
-       while (!pdu[i] && i < len)
-               i++;
+       static char zero[4096];
 
-       return i == len;
+       return !memcmp(pdu, zero, len);
 }
 
 static char *dump_pdu(unsigned char *pdu_buf, int pdu_len)