projects
/
linux-block.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
24fc595
)
net: move stale comment about ntuple validation
author
Jakub Kicinski
<kuba@kernel.org>
Fri, 14 Feb 2025 22:43:40 +0000
(14:43 -0800)
committer
Jakub Kicinski
<kuba@kernel.org>
Tue, 18 Feb 2025 00:47:01 +0000
(16:47 -0800)
Gal points out that the comment now belongs further down, since
the original if condition was split into two in
commit
de7f7582dff2
("net: ethtool: prevent flow steering to RSS contexts which don't exist")
Link:
https://lore.kernel.org/de4a2a8a-1eb9-4fa8-af87-7526e58218e9@nvidia.com
Reviewed-by: Gal Pressman <gal@nvidia.com>
Link:
https://patch.msgid.link/20250214224340.2268691-1-kuba@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/ethtool/ioctl.c
patch
|
blob
|
blame
|
history
diff --git
a/net/ethtool/ioctl.c
b/net/ethtool/ioctl.c
index 98b7dcea207a64d96192bf8e7008a23b53465ba7..271c7cef9ef3e30e856c58b64c8c578e01e49b11 100644
(file)
--- a/
net/ethtool/ioctl.c
+++ b/
net/ethtool/ioctl.c
@@
-992,8
+992,10
@@
static noinline_for_stack int ethtool_set_rxnfc(struct net_device *dev,
if (rc)
return rc;
- /* Nonzero ring with RSS only makes sense if NIC adds them together */
if (cmd == ETHTOOL_SRXCLSRLINS && info.fs.flow_type & FLOW_RSS) {
+ /* Nonzero ring with RSS only makes sense
+ * if NIC adds them together
+ */
if (!ops->cap_rss_rxnfc_adds &&
ethtool_get_flow_spec_ring(info.fs.ring_cookie))
return -EINVAL;