watchdog: uniphier: change order for setting default timeout
authorMarcus Folkesson <marcus.folkesson@gmail.com>
Sat, 10 Feb 2018 20:36:20 +0000 (21:36 +0100)
committerWim Van Sebroeck <wim@linux-watchdog.org>
Sat, 3 Mar 2018 16:04:15 +0000 (17:04 +0100)
watchdog_init_timeout() will preserve wdd->timeout value if no parameter
nor timeout-secs dt property is set.

Signed-off-by: Marcus Folkesson <marcus.folkesson@gmail.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Acked-by: Keiji Hayashibara <hayashibara.keiji@socionext.com>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Wim Van Sebroeck <wim@iguana.be>
drivers/watchdog/uniphier_wdt.c

index 0ea2339d9702844ade6ee3103c3e65ca9d9040ee..0e4f8d53ce3c71279836dbcb4262ec651bcf92f9 100644 (file)
@@ -212,11 +212,10 @@ static int uniphier_wdt_probe(struct platform_device *pdev)
        wdev->wdt_dev.ops = &uniphier_wdt_ops;
        wdev->wdt_dev.max_timeout = WDT_PERIOD_MAX;
        wdev->wdt_dev.min_timeout = WDT_PERIOD_MIN;
+       wdev->wdt_dev.timeout = WDT_DEFAULT_TIMEOUT;
        wdev->wdt_dev.parent = dev;
 
-       if (watchdog_init_timeout(&wdev->wdt_dev, timeout, dev) < 0) {
-               wdev->wdt_dev.timeout = WDT_DEFAULT_TIMEOUT;
-       }
+       watchdog_init_timeout(&wdev->wdt_dev, timeout, dev);
        watchdog_set_nowayout(&wdev->wdt_dev, nowayout);
        watchdog_stop_on_reboot(&wdev->wdt_dev);