drm/msm/adreno: Fix error return if missing firmware-name
authorRob Clark <robdclark@chromium.org>
Tue, 16 Jul 2024 16:06:30 +0000 (09:06 -0700)
committerRob Clark <robdclark@chromium.org>
Thu, 15 Aug 2024 17:12:07 +0000 (10:12 -0700)
-ENODEV is used to signify that there is no zap shader for the platform,
and the CPU can directly take the GPU out of secure mode.  We want to
use this return code when there is no zap-shader node.  But not when
there is, but without a firmware-name property.  This case we want to
treat as-if the needed fw is not found.

Signed-off-by: Rob Clark <robdclark@chromium.org>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Reviewed-by: Akhil P Oommen <quic_akhilpo@quicinc.com>
Patchwork: https://patchwork.freedesktop.org/patch/604564/

drivers/gpu/drm/msm/adreno/adreno_gpu.c

index 1c6626747b98fae4b3373be9bb6c1abf4f80e2bf..ecc3fc5cec22709adfce8ef4cad763e4a62bab5d 100644 (file)
@@ -99,7 +99,7 @@ static int zap_shader_load_mdt(struct msm_gpu *gpu, const char *fwname,
                 * was a bad idea, and is only provided for backwards
                 * compatibility for older targets.
                 */
-               return -ENODEV;
+               return -ENOENT;
        }
 
        if (IS_ERR(fw)) {