media: winbond-cir: Fix pnp_irq's error checking for wbcir_probe
authorArvind Yadav <arvind.yadav.cs@gmail.com>
Thu, 16 Nov 2017 04:37:51 +0000 (23:37 -0500)
committerMauro Carvalho Chehab <mchehab@s-opensource.com>
Thu, 14 Dec 2017 15:35:28 +0000 (10:35 -0500)
The pnp_irq() function returns -1 if an error occurs.
pnp_irq() error checking for zero is not correct.

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Signed-off-by: Sean Young <sean@mess.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
drivers/media/rc/winbond-cir.c

index 3ca7ab48293de971bfbf6b0dabc1527b00adc874..0adf0991f5abece70603ef65d11a3cbc4ff016fc 100644 (file)
@@ -1044,7 +1044,7 @@ wbcir_probe(struct pnp_dev *device, const struct pnp_device_id *dev_id)
        data->irq = pnp_irq(device, 0);
 
        if (data->wbase == 0 || data->ebase == 0 ||
-           data->sbase == 0 || data->irq == 0) {
+           data->sbase == 0 || data->irq == -1) {
                err = -ENODEV;
                dev_err(dev, "Invalid resources\n");
                goto exit_free_data;