phy: qcom-qmp-pcie-msm8996: rework regs layout arrays
authorDmitry Baryshkov <dmitry.baryshkov@linaro.org>
Thu, 10 Nov 2022 19:22:40 +0000 (22:22 +0300)
committerVinod Koul <vkoul@kernel.org>
Thu, 12 Jan 2023 17:18:41 +0000 (22:48 +0530)
Use symbolic names for the values inside reg layout arrays. New register
names are added following the PCS register layout that is used by the
particular PHY.

Note: ipq8074 tables appear to use a mixture of v2 and v3 registers.
This might need additional fixes.

Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Link: https://lore.kernel.org/r/20221110192248.873973-6-dmitry.baryshkov@linaro.org
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/phy/qualcomm/phy-qcom-qmp-pcie-msm8996.c

index a088477e274f74db9b127e813b21bfc4135a12d0..09824be088c96c0b6354ff0488068b17e573a34b 100644 (file)
@@ -84,9 +84,9 @@ static const unsigned int pciephy_regs_layout[QPHY_LAYOUT_SIZE] = {
        [QPHY_COM_POWER_DOWN_CONTROL]   = 0x404,
        [QPHY_COM_START_CONTROL]        = 0x408,
        [QPHY_COM_PCS_READY_STATUS]     = 0x448,
-       [QPHY_SW_RESET]                 = 0x00,
-       [QPHY_START_CTRL]               = 0x08,
-       [QPHY_PCS_STATUS]               = 0x174,
+       [QPHY_SW_RESET]                 = QPHY_V2_PCS_SW_RESET,
+       [QPHY_START_CTRL]               = QPHY_V2_PCS_START_CONTROL,
+       [QPHY_PCS_STATUS]               = QPHY_V2_PCS_PCI_PCS_STATUS,
 };
 
 static const struct qmp_phy_init_tbl msm8996_pcie_serdes_tbl[] = {