IB/hfi1: Clean up type used and casting
authorChristophe Jaillet <christophe.jaillet@wanadoo.fr>
Fri, 26 Aug 2016 04:49:25 +0000 (06:49 +0200)
committerDoug Ledford <dledford@redhat.com>
Fri, 26 Aug 2016 14:01:49 +0000 (10:01 -0400)
In all other places in this file where 'find_first_bit' is called,
port_num is defined as a 'u8' and no casting is done.

Do the same here in order to be more consistent.

Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Signed-off-by: Doug Ledford <dledford@redhat.com>
drivers/infiniband/hw/hfi1/mad.c

index 39e42c373a01c5e9afc276bb2073b214cde4515f..9912d2ca3ded5cf60dc1481f5256ff06d35b9aea 100644 (file)
@@ -2604,7 +2604,7 @@ static int pma_get_opa_datacounters(struct opa_pma_mad *pmp,
        u8 lq, num_vls;
        u8 res_lli, res_ler;
        u64 port_mask;
-       unsigned long port_num;
+       u8 port_num;
        unsigned long vl;
        u32 vl_select_mask;
        int vfi;
@@ -2640,7 +2640,7 @@ static int pma_get_opa_datacounters(struct opa_pma_mad *pmp,
        port_num = find_first_bit((unsigned long *)&port_mask,
                                  sizeof(port_mask));
 
-       if ((u8)port_num != port) {
+       if (port_num != port) {
                pmp->mad_hdr.status |= IB_SMP_INVALID_FIELD;
                return reply((struct ib_mad_hdr *)pmp);
        }