drm/i915/uncore: Warn only if unclaimed access remains flagged
authorLucas De Marchi <lucas.demarchi@intel.com>
Fri, 8 Apr 2022 16:48:37 +0000 (09:48 -0700)
committerLucas De Marchi <lucas.demarchi@intel.com>
Sat, 9 Apr 2022 16:32:40 +0000 (09:32 -0700)
Commit 4b276ed3c7ac ("drm/i915/uncore: Warn on previous unclaimed
accesses") tried to improve our report of unclaimed register access,
however it unveiled cases that were not previously causing any harm.

Downgrade the first message to debug so we can still see them and
eventually fix, but don't warn.

Fixes: 4b276ed3c7ac ("drm/i915/uncore: Warn on previous unclaimed accesses")
Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
Reviewed-by: Matt Roper <matthew.d.roper@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20220408164837.3845786-1-lucas.demarchi@intel.com
drivers/gpu/drm/i915/intel_uncore.c

index 4dc66d56315eb6eec060ff09f734e9864f66c9ff..24cd3c3729ca273fae9c43a45622fabbc7a9f077 100644 (file)
@@ -1518,13 +1518,11 @@ __unclaimed_previous_reg_debug(struct intel_uncore *uncore,
                               const i915_reg_t reg,
                               const bool read)
 {
-       if (drm_WARN(&uncore->i915->drm,
-                    check_for_unclaimed_mmio(uncore),
-                    "Unclaimed access detected before %s register 0x%x\n",
-                    read ? "read from" : "write to",
-                    i915_mmio_reg_offset(reg)))
-               /* Only report the first N failures */
-               uncore->i915->params.mmio_debug--;
+       if (check_for_unclaimed_mmio(uncore))
+               drm_dbg(&uncore->i915->drm,
+                       "Unclaimed access detected before %s register 0x%x\n",
+                       read ? "read from" : "write to",
+                       i915_mmio_reg_offset(reg));
 }
 
 static inline void