i2c: imx: Use dev_err_probe() to simplify error handling
authorAnson Huang <Anson.Huang@nxp.com>
Wed, 12 Aug 2020 03:45:54 +0000 (11:45 +0800)
committerWolfram Sang <wsa@kernel.org>
Wed, 9 Sep 2020 08:32:10 +0000 (10:32 +0200)
dev_err_probe() can reduce code size, uniform error handling and record the
defer probe reason etc., use it to simplify the code.

Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
Acked-by: Oleksij Rempel <o.rempel@pengutronix.de>
Signed-off-by: Wolfram Sang <wsa@kernel.org>
drivers/i2c/busses/i2c-imx.c

index 0ab5381aa012787069a39e9631df2e2ffd666f72..63f4367c312b375b5a005cf0f56cf58cff6c0be8 100644 (file)
@@ -1159,11 +1159,9 @@ static int i2c_imx_probe(struct platform_device *pdev)
 
        /* Get I2C clock */
        i2c_imx->clk = devm_clk_get(&pdev->dev, NULL);
-       if (IS_ERR(i2c_imx->clk)) {
-               if (PTR_ERR(i2c_imx->clk) != -EPROBE_DEFER)
-                       dev_err(&pdev->dev, "can't get I2C clock\n");
-               return PTR_ERR(i2c_imx->clk);
-       }
+       if (IS_ERR(i2c_imx->clk))
+               return dev_err_probe(&pdev->dev, PTR_ERR(i2c_imx->clk),
+                                    "can't get I2C clock\n");
 
        ret = clk_prepare_enable(i2c_imx->clk);
        if (ret) {