watchdog: handle comma separated nmi_watchdog command line
authorSong Liu <song@kernel.org>
Tue, 30 Apr 2024 06:02:35 +0000 (23:02 -0700)
committerAndrew Morton <akpm@linux-foundation.org>
Wed, 8 May 2024 15:41:28 +0000 (08:41 -0700)
Per the document, the kernel can accept comma separated command line like
nmi_watchdog=nopanic,0.  However, the code doesn't really handle it.  Fix
the kernel to handle it properly.

Link: https://lkml.kernel.org/r/20240430060236.1878002-1-song@kernel.org
Signed-off-by: Song Liu <song@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
kernel/watchdog.c

index d7b2125503af3dd6f9d4b03eee38c14f8d9b3212..7f54484de16f7ad303a446d428bcf0149d156742 100644 (file)
@@ -71,6 +71,7 @@ void __init hardlockup_detector_disable(void)
 
 static int __init hardlockup_panic_setup(char *str)
 {
+next:
        if (!strncmp(str, "panic", 5))
                hardlockup_panic = 1;
        else if (!strncmp(str, "nopanic", 7))
@@ -79,6 +80,12 @@ static int __init hardlockup_panic_setup(char *str)
                watchdog_hardlockup_user_enabled = 0;
        else if (!strncmp(str, "1", 1))
                watchdog_hardlockup_user_enabled = 1;
+       while (*(str++)) {
+               if (*str == ',') {
+                       str++;
+                       goto next;
+               }
+       }
        return 1;
 }
 __setup("nmi_watchdog=", hardlockup_panic_setup);