projects
/
linux-block.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
7847718
)
ASoC: qcom: lpass-platform: fix memory leak
author
Rohit kumar
<rohitkr@codeaurora.org>
Fri, 14 Aug 2020 10:53:00 +0000
(16:23 +0530)
committer
Mark Brown
<broonie@kernel.org>
Mon, 17 Aug 2020 13:39:28 +0000
(14:39 +0100)
lpass_pcm_data is never freed. Free it in close
ops to avoid memory leak.
Fixes:
022d00ee0b55
("ASoC: lpass-platform: Fix broken pcm data usage")
Signed-off-by: Rohit kumar <rohitkr@codeaurora.org>
Reviewed-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Link:
https://lore.kernel.org/r/1597402388-14112-5-git-send-email-rohitkr@codeaurora.org
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/qcom/lpass-platform.c
patch
|
blob
|
blame
|
history
diff --git
a/sound/soc/qcom/lpass-platform.c
b/sound/soc/qcom/lpass-platform.c
index 3697f4ee63a00c04bb4df4e448ee771546c1c5d3..315feda414d9052540a5e2c4a9d6b7a2278a31ce 100644
(file)
--- a/
sound/soc/qcom/lpass-platform.c
+++ b/
sound/soc/qcom/lpass-platform.c
@@
-61,7
+61,7
@@
static int lpass_platform_pcmops_open(struct snd_soc_component *component,
int ret, dma_ch, dir = substream->stream;
struct lpass_pcm_data *data;
- data =
devm_kzalloc(soc_runtime->dev,
sizeof(*data), GFP_KERNEL);
+ data =
kzalloc(
sizeof(*data), GFP_KERNEL);
if (!data)
return -ENOMEM;
@@
-118,6
+118,7
@@
static int lpass_platform_pcmops_close(struct snd_soc_component *component,
if (v->free_dma_channel)
v->free_dma_channel(drvdata, data->dma_ch);
+ kfree(data);
return 0;
}