ASoC: intel/sdw_utils: Assign initial value in asoc_sdw_rt_amp_spk_rtd_init()
authorI Hsin Cheng <richard120310@gmail.com>
Mon, 5 May 2025 18:54:23 +0000 (02:54 +0800)
committerMark Brown <broonie@kernel.org>
Wed, 14 May 2025 13:15:57 +0000 (15:15 +0200)
Initialize "ret" with "-EINVAL" to handle cases where "strstr()" for
"codec_dai->component->name_prefix" doesn't find "-1" nor "-2". In that
case "name_prefix" is invalid because for current implementation it's
expected to have either "-1" or "-2" in it. (Maybe "-3", "-4" and so on
in the future.)

Link: https://scan5.scan.coverity.com/#/project-view/36179/10063?selectedIssue=1627120
Signed-off-by: I Hsin Cheng <richard120310@gmail.com>
Link: https://patch.msgid.link/20250505185423.680608-1-richard120310@gmail.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/sdw_utils/soc_sdw_rt_amp.c

index 0538c252ba69b1f5a24ba2de2a610b22d0c0665f..83c2368170cb5eaebd50c23e533dea2ae771dd74 100644 (file)
@@ -190,7 +190,7 @@ int asoc_sdw_rt_amp_spk_rtd_init(struct snd_soc_pcm_runtime *rtd, struct snd_soc
        const struct snd_soc_dapm_route *rt_amp_map;
        char codec_name[CODEC_NAME_SIZE];
        struct snd_soc_dai *codec_dai;
-       int ret;
+       int ret = -EINVAL;
        int i;
 
        rt_amp_map = get_codec_name_and_route(dai, codec_name);