btrfs: remove duplicate error check at btrfs_convert_extent_bit()

There's no need to check if split_state() returned an error twice, instead
unify into a single if statement after setting 'prealloc' to NULL, because
on error split_state() frees the 'prealloc' extent state record.

Signed-off-by: Filipe Manana <fdmanana@suse.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>

diff --git a/fs/btrfs/extent-io-tree.c b/fs/btrfs/extent-io-tree.c
index 55334c616d6dcb7c4241d612af2bb89a256288e8..2c004e0c431d8f2e751bb9aadaa210d5e0cd9c28 100644 (file)
--- a/fs/btrfs/extent-io-tree.c
+++ b/fs/btrfs/extent-io-tree.c
@@ -1389,11 +1389,11 @@ hit_next:
                        goto out;
                }
                ret = split_state(tree, state, prealloc, start);
-               if (ret)
-                       extent_io_tree_panic(tree, state, "split", ret);
                prealloc = NULL;
-               if (ret)
+               if (ret) {
+                       extent_io_tree_panic(tree, state, "split", ret);
                        goto out;
+               }
                if (state->end <= end) {
                        set_state_bits(tree, state, bits, NULL);
                        cache_state(state, cached_state);