rtlwifi: rtl_pci: Simplify some code be eliminating extraneous variables
authorLarry Finger <Larry.Finger@lwfinger.net>
Wed, 1 Nov 2017 15:29:18 +0000 (10:29 -0500)
committerKalle Valo <kvalo@codeaurora.org>
Wed, 8 Nov 2017 12:30:16 +0000 (14:30 +0200)
In several places, the code assigns a variable inside an "if" or "case"
block, but uses it only once. The code is simplified by eliminating
the extraneous variable. With this change, one level of indenting is
saved.

This patch does not cause any functional changes in the binary code.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Cc: Ping-Ke Shih <pkshih@realtek.com>
Cc: Yan-Hsuan Chuang <yhchuang@realtek.com>
Cc: Birming Chiu <birming@realtek.com>
Cc: Shaofu <shaofu@realtek.com>
Cc: Steven Ting <steventing@realtek.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
drivers/net/wireless/realtek/rtlwifi/pci.c

index 7325806e40a27978fe53f0f405167f59c8a7840f..01c65c80712648b60a56e834ae82ebb763d554ac 100644 (file)
@@ -143,32 +143,19 @@ static void _rtl_pci_update_default_setting(struct ieee80211_hw *hw)
 
        /*Set HW definition to determine if it supports ASPM. */
        switch (rtlpci->const_support_pciaspm) {
-       case 0:{
-                       /*Not support ASPM. */
-                       bool support_aspm = false;
-                       ppsc->support_aspm = support_aspm;
-                       break;
-               }
-       case 1:{
-                       /*Support ASPM. */
-                       bool support_aspm = true;
-                       bool support_backdoor = true;
-                       ppsc->support_aspm = support_aspm;
-
-                       /*if (priv->oem_id == RT_CID_TOSHIBA &&
-                          !priv->ndis_adapter.amd_l1_patch)
-                          support_backdoor = false; */
-
-                       ppsc->support_backdoor = support_backdoor;
-
-                       break;
-               }
+       case 0:
+               /*Not support ASPM. */
+               ppsc->support_aspm = false;
+               break;
+       case 1:
+               /*Support ASPM. */
+               ppsc->support_aspm = true;
+               ppsc->support_backdoor = true;
+               break;
        case 2:
                /*ASPM value set by chipset. */
-               if (pcibridge_vendor == PCI_BRIDGE_VENDOR_INTEL) {
-                       bool support_aspm = true;
-                       ppsc->support_aspm = support_aspm;
-               }
+               if (pcibridge_vendor == PCI_BRIDGE_VENDOR_INTEL)
+                       ppsc->support_aspm = true;
                break;
        default:
                pr_err("switch case %#x not processed\n",