crypto: lzo - get rid of superfluous __GFP_REPEAT
authorMichal Hocko <mhocko@suse.com>
Thu, 14 Apr 2016 08:51:42 +0000 (10:51 +0200)
committerHerbert Xu <herbert@gondor.apana.org.au>
Fri, 15 Apr 2016 14:36:36 +0000 (22:36 +0800)
__GFP_REPEAT has a rather weak semantic but since it has been introduced
around 2.6.12 it has been ignored for low order allocations.

lzo_init uses __GFP_REPEAT to allocate LZO1X_MEM_COMPRESS 16K. This is
order 3 allocation request and __GFP_REPEAT is ignored for this size
as well as all <= PAGE_ALLOC_COSTLY requests.

Cc: Herbert Xu <herbert@gondor.apana.org.au>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: linux-crypto@vger.kernel.org
Signed-off-by: Michal Hocko <mhocko@suse.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
crypto/lzo.c

index 4b3e92525dac5a47f3415f46c9eb403813b44275..c3f3dd9a28c5eb1ca8546272ebec13f3f0a84cc3 100644 (file)
@@ -32,7 +32,7 @@ static int lzo_init(struct crypto_tfm *tfm)
        struct lzo_ctx *ctx = crypto_tfm_ctx(tfm);
 
        ctx->lzo_comp_mem = kmalloc(LZO1X_MEM_COMPRESS,
-                                   GFP_KERNEL | __GFP_NOWARN | __GFP_REPEAT);
+                                   GFP_KERNEL | __GFP_NOWARN);
        if (!ctx->lzo_comp_mem)
                ctx->lzo_comp_mem = vmalloc(LZO1X_MEM_COMPRESS);
        if (!ctx->lzo_comp_mem)