selftests: net: packetdrill: xfail all problems on slow machines
authorJakub Kicinski <kuba@kernel.org>
Fri, 1 Aug 2025 18:16:38 +0000 (11:16 -0700)
committerJakub Kicinski <kuba@kernel.org>
Tue, 5 Aug 2025 00:21:44 +0000 (17:21 -0700)
We keep seeing flakes on packetdrill on debug kernels, while
non-debug kernels are stable, not a single flake in 200 runs.
Time to give up, debug kernels appear to suffer from 10msec
latency spikes and any timing-sensitive test is bound to flake.

Reviewed-by: Willem de Bruijn <willemb@google.com>
Acked-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
Link: https://patch.msgid.link/20250801181638.2483531-1-kuba@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
tools/testing/selftests/net/packetdrill/ksft_runner.sh

index c5b01e1bd4c79ba0bb9f7a0244e0a1200c3c517e..a7e790af38ffc37cdf26e8859257753524ab9470 100755 (executable)
@@ -35,24 +35,7 @@ failfunc=ktap_test_fail
 
 if [[ -n "${KSFT_MACHINE_SLOW}" ]]; then
        optargs+=('--tolerance_usecs=14000')
-
-       # xfail tests that are known flaky with dbg config, not fixable.
-       # still run them for coverage (and expect 100% pass without dbg).
-       declare -ar xfail_list=(
-               "tcp_blocking_blocking-connect.pkt"
-               "tcp_blocking_blocking-read.pkt"
-               "tcp_eor_no-coalesce-retrans.pkt"
-               "tcp_fast_recovery_prr-ss.*.pkt"
-               "tcp_sack_sack-route-refresh-ip-tos.pkt"
-               "tcp_slow_start_slow-start-after-win-update.pkt"
-               "tcp_timestamping.*.pkt"
-               "tcp_user_timeout_user-timeout-probe.pkt"
-               "tcp_zerocopy_cl.*.pkt"
-               "tcp_zerocopy_epoll_.*.pkt"
-               "tcp_tcp_info_tcp-info-.*-limited.pkt"
-       )
-       readonly xfail_regex="^($(printf '%s|' "${xfail_list[@]}"))$"
-       [[ "$script" =~ ${xfail_regex} ]] && failfunc=ktap_test_xfail
+       failfunc=ktap_test_xfail
 fi
 
 ktap_print_header