net: dsa: mv88e6xxx: Fix uninitialised err value
authorAryan Srivastava <aryan.srivastava@alliedtelesis.co.nz>
Wed, 9 Oct 2024 21:23:19 +0000 (10:23 +1300)
committerJakub Kicinski <kuba@kernel.org>
Fri, 11 Oct 2024 22:43:24 +0000 (15:43 -0700)
The err value in mv88e6xxx_region_atu_snapshot is now potentially
uninitialised on return. Initialise err as 0.

Fixes: ada5c3229b32 ("net: dsa: mv88e6xxx: Add FID map cache")
Signed-off-by: Aryan Srivastava <aryan.srivastava@alliedtelesis.co.nz>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Link: https://patch.msgid.link/20241009212319.1045176-1-aryan.srivastava@alliedtelesis.co.nz
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/dsa/mv88e6xxx/devlink.c

index ef3643bc43dbba819f31d662f81b3f6958ef8eff..795c8df7b6a7430619ba675a6c8155f577b99f5c 100644 (file)
@@ -376,7 +376,7 @@ static int mv88e6xxx_region_atu_snapshot(struct devlink *dl,
        struct dsa_switch *ds = dsa_devlink_to_ds(dl);
        struct mv88e6xxx_devlink_atu_entry *table;
        struct mv88e6xxx_chip *chip = ds->priv;
-       int fid = -1, count, err;
+       int fid = -1, err = 0, count;
 
        table = kmalloc_array(mv88e6xxx_num_databases(chip),
                              sizeof(struct mv88e6xxx_devlink_atu_entry),