mac80211: fix rx reordering with non explicit / psmp ack policy
authorFelix Fietkau <nbd@nbd.name>
Wed, 20 Apr 2022 10:50:38 +0000 (12:50 +0200)
committerJohannes Berg <johannes.berg@intel.com>
Wed, 4 May 2022 09:33:23 +0000 (11:33 +0200)
When the QoS ack policy was set to non explicit / psmp ack, frames are treated
as not being part of a BA session, which causes extra latency on reordering.
Fix this by only bypassing reordering for packets with no-ack policy

Signed-off-by: Felix Fietkau <nbd@nbd.name>
Link: https://lore.kernel.org/r/20220420105038.36443-1-nbd@nbd.name
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
net/mac80211/rx.c

index beb6b92eb7804759dddcc3cef2efb68a4338dc9d..88d797fa82ff64c0d1aad14a45bf6ff05ea1c619 100644 (file)
@@ -1405,8 +1405,7 @@ static void ieee80211_rx_reorder_ampdu(struct ieee80211_rx_data *rx,
                goto dont_reorder;
 
        /* not part of a BA session */
-       if (ack_policy != IEEE80211_QOS_CTL_ACK_POLICY_BLOCKACK &&
-           ack_policy != IEEE80211_QOS_CTL_ACK_POLICY_NORMAL)
+       if (ack_policy == IEEE80211_QOS_CTL_ACK_POLICY_NOACK)
                goto dont_reorder;
 
        /* new, potentially un-ordered, ampdu frame - process it */