gpio: mpsse: Check for error code from devm_mutex_init() call
authorAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Wed, 30 Oct 2024 17:36:51 +0000 (19:36 +0200)
committerBartosz Golaszewski <bartosz.golaszewski@linaro.org>
Thu, 31 Oct 2024 12:47:36 +0000 (13:47 +0100)
Even if it's not critical, the avoidance of checking the error code
from devm_mutex_init() call today diminishes the point of using devm
variant of it. Tomorrow it may even leak something. Add the missed
check.

Fixes: c46a74ff05c0 ("gpio: add support for FTDI's MPSSE as GPIO")
Reviewed-by: Mary Strodl <mstrodl@csh.rit.edu>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Link: https://lore.kernel.org/r/20241030174132.2113286-2-andriy.shevchenko@linux.intel.com
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
drivers/gpio/gpio-mpsse.c

index 3ab6651d222676f38224f3115f6f66dd6ec0eaaa..9ef24449126a7d261dc66fdf6e1013ee9e50f46c 100644 (file)
@@ -430,8 +430,13 @@ static int gpio_mpsse_probe(struct usb_interface *interface,
        if (err)
                return err;
 
-       devm_mutex_init(dev, &priv->io_mutex);
-       devm_mutex_init(dev, &priv->irq_mutex);
+       err = devm_mutex_init(dev, &priv->io_mutex);
+       if (err)
+               return err;
+
+       err = devm_mutex_init(dev, &priv->irq_mutex);
+       if (err)
+               return err;
 
        priv->gpio.label = devm_kasprintf(dev, GFP_KERNEL,
                                          "gpio-mpsse.%d.%d",