sh_eth: align usage of sh_eth_modify() with rest of driver
authorNiklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
Wed, 1 Feb 2017 14:41:54 +0000 (15:41 +0100)
committerDavid S. Miller <davem@davemloft.net>
Wed, 1 Feb 2017 17:53:58 +0000 (12:53 -0500)
To be consistent with the rest of the driver when setting bits using
sh_eth_modify() the same bit should also be cleared. This have no
functional change and should have been done from the start.

Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
Suggested-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Acked-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/renesas/sh_eth.c

index 2f08d2735fe25e4dee67231cc6b58f2616c9f3ed..f9134c818ac6ef533710b438d933a636d98bf9fa 100644 (file)
@@ -3271,7 +3271,7 @@ static int sh_eth_wol_setup(struct net_device *ndev)
        sh_eth_write(ndev, EESIPR_ECIIP, EESIPR);
 
        /* Enable MagicPacket */
-       sh_eth_modify(ndev, ECMR, 0, ECMR_MPDE);
+       sh_eth_modify(ndev, ECMR, ECMR_MPDE, ECMR_MPDE);
 
        /* Increased clock usage so device won't be suspended */
        clk_enable(mdp->clk);