Merge tag 'for-linus-4.10-ofs1' of git://git.kernel.org/pub/scm/linux/kernel/git...
authorLinus Torvalds <torvalds@linux-foundation.org>
Thu, 15 Dec 2016 21:41:55 +0000 (13:41 -0800)
committerLinus Torvalds <torvalds@linux-foundation.org>
Thu, 15 Dec 2016 21:41:55 +0000 (13:41 -0800)
Pull orangefs updates from Mike Marshall:
 "Two small fixes sent in by other developers:

   - axe some dead code (Christophe Jaillet)

   - fix memory leak (Colin Ian King, found by Coverity)"

* tag 'for-linus-4.10-ofs1' of git://git.kernel.org/pub/scm/linux/kernel/git/hubcap/linux:
  orangefs: Axe some dead code
  orangefs: fix memory leak of string 'new' on exit path

fs/orangefs/orangefs-debugfs.c
fs/orangefs/orangefs-sysfs.c

index 38887cc5577fa901acd907a0af2fb016a3441b2c..b5dbc9c6530cbcd6f6cdc5498ac1c8fa214c84de 100644 (file)
@@ -671,8 +671,10 @@ int orangefs_prepare_debugfs_help_string(int at_boot)
                 */
                cdm_element_count =
                        orangefs_prepare_cdm_array(client_debug_array_string);
-               if (cdm_element_count <= 0)
+               if (cdm_element_count <= 0) {
+                       kfree(new);
                        goto out;
+               }
 
                for (i = 0; i < cdm_element_count; i++) {
                        strlcat(new, "\t", string_size);
index a799546a67f779ef92f30f3bf959c3fd177b9292..084954448f1868840cbf3291cbb226206c2ffd51 100644 (file)
@@ -609,15 +609,6 @@ static ssize_t sysfs_service_op_store(struct kobject *kobj,
                        new_op->upcall.req.param.u.value32[0] = val1;
                        new_op->upcall.req.param.u.value32[1] = val2;
                        goto value_set;
-               } else if (!strcmp(attr->attr.name,
-                                  "perf_counter_reset")) {
-                       if ((val > 0)) {
-                               new_op->upcall.req.param.op =
-                               ORANGEFS_PARAM_REQUEST_OP_READAHEAD_COUNT_SIZE;
-                       } else {
-                               rc = 0;
-                               goto out;
-                       }
                }
 
        } else if (!strcmp(kobj->name, ACACHE_KOBJ_ID)) {