staging: unisys: visorbus: add error handling visorbus_enable_channel_interrupt
authorDavid Kershner <david.kershner@unisys.com>
Tue, 28 Mar 2017 13:34:44 +0000 (09:34 -0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 29 Mar 2017 07:17:03 +0000 (09:17 +0200)
Add error handling to visorbus_enable_channel_interrupt.

Signed-off-by: David Kershner <david.kershner@unisys.com>
Reviewed-by: Reviewed-by: Tim Sell <timothy.sell@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/unisys/include/visorbus.h
drivers/staging/unisys/visorbus/visorbus_main.c

index 65829391b3bf45fb8818ca15a62a6aa3e18347f6..de0635542fbd029e7713d8470b87ee25859cd002 100644 (file)
@@ -180,7 +180,7 @@ int visorbus_read_channel(struct visor_device *dev,
 int visorbus_write_channel(struct visor_device *dev,
                           unsigned long offset, void *src,
                           unsigned long nbytes);
-void visorbus_enable_channel_interrupts(struct visor_device *dev);
+int visorbus_enable_channel_interrupts(struct visor_device *dev);
 void visorbus_disable_channel_interrupts(struct visor_device *dev);
 
 /* Levels of severity for diagnostic events, in order from lowest severity to
index c97f32f5c235ee46e693d8f8631e21c9830f2d47..bf0f191e79d3e80ba4c91d61c7aa0549a1c74b15 100644 (file)
@@ -580,17 +580,17 @@ EXPORT_SYMBOL_GPL(visorbus_write_channel);
  * Currently we don't yet have a real interrupt, so for now we just call the
  * interrupt function periodically via a timer.
  */
-void
+int
 visorbus_enable_channel_interrupts(struct visor_device *dev)
 {
        struct visor_driver *drv = to_visor_driver(dev->device.driver);
 
        if (!drv->channel_interrupt) {
                dev_err(&dev->device, "%s no interrupt function!\n", __func__);
-               return;
+               return -ENOENT;
        }
 
-       dev_start_periodic_work(dev);
+       return dev_start_periodic_work(dev);
 }
 EXPORT_SYMBOL_GPL(visorbus_enable_channel_interrupts);