drm/amd/display: Check HDCP returned status

[WHAT & HOW]
Check mod_hdcp_execute_and_set() return values in authenticated_dp.

This fixes 3 CHECKED_RETURN issues reported by Coverity.

Reviewed-by: Rodrigo Siqueira <rodrigo.siqueira@amd.com>
Signed-off-by: Alex Hung <alex.hung@amd.com>
Tested-by: Daniel Wheeler <daniel.wheeler@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>

diff --git a/drivers/gpu/drm/amd/display/modules/hdcp/hdcp1_execution.c b/drivers/gpu/drm/amd/display/modules/hdcp/hdcp1_execution.c
index 182e7532dda8a177748c61abb984cbb36977eda3..d77836cef563571ad88b66cb10a90f4872515b3d 100644 (file)
--- a/drivers/gpu/drm/amd/display/modules/hdcp/hdcp1_execution.c
+++ b/drivers/gpu/drm/amd/display/modules/hdcp/hdcp1_execution.c
@@ -433,17 +433,20 @@ static enum mod_hdcp_status authenticated_dp(struct mod_hdcp *hdcp,
        }
 
        if (status == MOD_HDCP_STATUS_SUCCESS)
-               mod_hdcp_execute_and_set(mod_hdcp_read_bstatus,
+               if (!mod_hdcp_execute_and_set(mod_hdcp_read_bstatus,
                                &input->bstatus_read, &status,
-                               hdcp, "bstatus_read");
+                               hdcp, "bstatus_read"))
+                       goto out;
        if (status == MOD_HDCP_STATUS_SUCCESS)
-               mod_hdcp_execute_and_set(check_link_integrity_dp,
+               if (!mod_hdcp_execute_and_set(check_link_integrity_dp,
                                &input->link_integrity_check, &status,
-                               hdcp, "link_integrity_check");
+                               hdcp, "link_integrity_check"))
+                       goto out;
        if (status == MOD_HDCP_STATUS_SUCCESS)
-               mod_hdcp_execute_and_set(check_no_reauthentication_request_dp,
+               if (!mod_hdcp_execute_and_set(check_no_reauthentication_request_dp,
                                &input->reauth_request_check, &status,
-                               hdcp, "reauth_request_check");
+                               hdcp, "reauth_request_check"))
+                       goto out;
 out:
        return status;
 }