projects
/
linux-block.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
1909a43
)
scsi: qla1280: make qla1280_firmware_mutex and qla1280_fw_tbl static
author
Jason Yan
<yanaijie@huawei.com>
Thu, 9 Apr 2020 08:49:10 +0000
(16:49 +0800)
committer
Martin K. Petersen
<martin.petersen@oracle.com>
Wed, 15 Apr 2020 01:42:10 +0000
(21:42 -0400)
Fix the following sparse warning:
drivers/scsi/qla1280.c:529:1: warning: symbol 'qla1280_firmware_mutex'
was not declared. Should it be static?
drivers/scsi/qla1280.c:538:15: warning: symbol 'qla1280_fw_tbl' was not
declared. Should it be static?
Link:
https://lore.kernel.org/r/20200409084910.44336-1-yanaijie@huawei.com
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Jason Yan <yanaijie@huawei.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/qla1280.c
patch
|
blob
|
blame
|
history
diff --git
a/drivers/scsi/qla1280.c
b/drivers/scsi/qla1280.c
index 3337cd341d210450fecb079026a10db2bf30eb9b..441a453493490c0f929811318bef9323ca061e0b 100644
(file)
--- a/
drivers/scsi/qla1280.c
+++ b/
drivers/scsi/qla1280.c
@@
-526,7
+526,7
@@
static struct pci_device_id qla1280_pci_tbl[] = {
};
MODULE_DEVICE_TABLE(pci, qla1280_pci_tbl);
-DEFINE_MUTEX(qla1280_firmware_mutex);
+
static
DEFINE_MUTEX(qla1280_firmware_mutex);
struct qla_fw {
char *fwname;
@@
-535,7
+535,7
@@
struct qla_fw {
#define QL_NUM_FW_IMAGES 3
-struct qla_fw qla1280_fw_tbl[QL_NUM_FW_IMAGES] = {
+st
atic st
ruct qla_fw qla1280_fw_tbl[QL_NUM_FW_IMAGES] = {
{"qlogic/1040.bin", NULL}, /* image 0 */
{"qlogic/1280.bin", NULL}, /* image 1 */
{"qlogic/12160.bin", NULL}, /* image 2 */