drm/amd/display: Remove redundant ternary operation
authorIvan Lipski <ivlipski@amd.com>
Fri, 31 May 2024 20:05:27 +0000 (16:05 -0400)
committerAlex Deucher <alexander.deucher@amd.com>
Fri, 14 Jun 2024 20:17:13 +0000 (16:17 -0400)
[WHY]
Coverity analysis flagged this ternary operation as
DEADCODE.

Since 'total_y_free_entry' is initialized as 0x200 and
'total_c_free_entry' is initialized as 0x140, and they
never change values before the ternary operator, so
'total_y_free_entry' is always greater 'total_c_free_entry',
'so small_free_entry' is always set to 'total_c_free_entry'.

[HOW]
Replace the ternary operator with the variable declaration.

Signed-off-by: Ivan Lipski <ivlipski@amd.com>
Acked-by: Zaeem Mohamed <zaeem.mohamed@amd.com>
Tested-by: Daniel Wheeler <daniel.wheeler@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/display/dc/resource/dcn20/dcn20_resource.c

index b2d79c908ec2ade3324a5de776b28f81e45310ef..f93853d434d20d4640b2575061cb52357f2c1972 100644 (file)
@@ -1612,7 +1612,7 @@ unsigned int dcn20_calc_max_scaled_time(
        if (time_per_byte == 0)
                time_per_byte = 1;
 
-       small_free_entry  = (total_y_free_entry > total_c_free_entry) ? total_c_free_entry : total_y_free_entry;
+       small_free_entry  = total_c_free_entry;
        max_free_entry    = (mode == PACKED_444) ? total_y_free_entry + total_c_free_entry : small_free_entry;
        buf_lh_capability = max_free_entry*time_per_byte*32/16; /* there is 4bit fraction */
        max_scaled_time   = buf_lh_capability - urgent_watermark;