mtd: spi-nor: sfdp: do not make invalid quad enable fatal
authorPratyush Yadav <p.yadav@ti.com>
Tue, 23 Jun 2020 18:30:24 +0000 (00:00 +0530)
committerTudor Ambarus <tudor.ambarus@microchip.com>
Mon, 13 Jul 2020 07:43:19 +0000 (10:43 +0300)
The Micron MT35XU512ABA flash does not support the quad enable bit. But
instead of programming the Quad Enable Require field to 000b ("Device
does not have a QE bit"), it is programmed to 111b ("Reserved").

While this is technically incorrect, it is not reason enough to abort
BFPT parsing. Instead, continue BFPT parsing and let flashes set it in
their fixup hooks.

Signed-off-by: Pratyush Yadav <p.yadav@ti.com>
Signed-off-by: Tudor Ambarus <tudor.ambarus@microchip.com>
Link: https://lore.kernel.org/r/20200623183030.26591-12-p.yadav@ti.com
drivers/mtd/spi-nor/sfdp.c

index 55c0c508464bcb0131c404dbd6a4b60cb04df684..e2a43d39eb5f40556f55f98a927f8a66201014bf 100644 (file)
@@ -598,7 +598,8 @@ static int spi_nor_parse_bfpt(struct spi_nor *nor,
                break;
 
        default:
-               return -EINVAL;
+               dev_dbg(nor->dev, "BFPT QER reserved value used\n");
+               break;
        }
 
        /* Stop here if not JESD216 rev C or later. */