drm/amdgpu: Drop redundant unsigned >=0 comparision 'amdgpu_gfx_rlc_init_microcode()'
authorSrinivasan Shanmugam <srinivasan.shanmugam@amd.com>
Wed, 20 Dec 2023 14:37:54 +0000 (20:07 +0530)
committerAlex Deucher <alexander.deucher@amd.com>
Wed, 3 Jan 2024 16:16:06 +0000 (11:16 -0500)
unsigned int "version_minor" is always >= 0

Fixes the below:
drivers/gpu/drm/amd/amdgpu/amdgpu_rlc.c:534 amdgpu_gfx_rlc_init_microcode() warn: always true condition '(version_minor >= 0) => (0-u16max >= 0)'

Cc: Christian König <christian.koenig@amd.com>
Cc: Alex Deucher <alexander.deucher@amd.com>
Signed-off-by: Srinivasan Shanmugam <srinivasan.shanmugam@amd.com>
Reviewed-by: Tao Zhou <tao.zhou1@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/amdgpu/amdgpu_rlc.c

index 35e0ae9acadcd616a056c73dd96960c3f8937569..2c3675d91614f13b21e35a08d57c5fc7bca32090 100644 (file)
@@ -531,13 +531,12 @@ int amdgpu_gfx_rlc_init_microcode(struct amdgpu_device *adev,
        if (version_major == 2 && version_minor == 1)
                adev->gfx.rlc.is_rlc_v2_1 = true;
 
-       if (version_minor >= 0) {
-               err = amdgpu_gfx_rlc_init_microcode_v2_0(adev);
-               if (err) {
-                       dev_err(adev->dev, "fail to init rlc v2_0 microcode\n");
-                       return err;
-               }
+       err = amdgpu_gfx_rlc_init_microcode_v2_0(adev);
+       if (err) {
+               dev_err(adev->dev, "fail to init rlc v2_0 microcode\n");
+               return err;
        }
+
        if (version_minor >= 1)
                amdgpu_gfx_rlc_init_microcode_v2_1(adev);
        if (version_minor >= 2)