net: sfp-bus: constify link_modes to sfp_select_interface()
authorRussell King (Oracle) <rmk+kernel@armlinux.org.uk>
Sun, 28 Apr 2024 14:51:12 +0000 (15:51 +0100)
committerPaolo Abeni <pabeni@redhat.com>
Tue, 30 Apr 2024 13:26:28 +0000 (15:26 +0200)
sfp_select_interface() does not modify its link_modes argument, so
make this a const pointer.

Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
Reviewed-by: Daniel Machon <daniel.machon@microchip.com>
Link: https://lore.kernel.org/r/E1s15s0-00AHyq-8E@rmk-PC.armlinux.org.uk
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
drivers/net/phy/sfp-bus.c
include/linux/sfp.h

index c6e3baf00f236da8af7e7484629fdba7957c9f15..37c85f1e6534e216932bef64080780b2ed44e34d 100644 (file)
@@ -355,7 +355,7 @@ EXPORT_SYMBOL_GPL(sfp_parse_support);
  * modes mask.
  */
 phy_interface_t sfp_select_interface(struct sfp_bus *bus,
-                                    unsigned long *link_modes)
+                                    const unsigned long *link_modes)
 {
        if (phylink_test(link_modes, 25000baseCR_Full) ||
            phylink_test(link_modes, 25000baseKR_Full) ||
index 55c0ab17c9e2e5d190f10ddcbfeb9993a098999c..5ebc57f78c95542c88e3faf3acd9544766be6665 100644 (file)
@@ -554,7 +554,7 @@ bool sfp_may_have_phy(struct sfp_bus *bus, const struct sfp_eeprom_id *id);
 void sfp_parse_support(struct sfp_bus *bus, const struct sfp_eeprom_id *id,
                       unsigned long *support, unsigned long *interfaces);
 phy_interface_t sfp_select_interface(struct sfp_bus *bus,
-                                    unsigned long *link_modes);
+                                    const unsigned long *link_modes);
 
 int sfp_get_module_info(struct sfp_bus *bus, struct ethtool_modinfo *modinfo);
 int sfp_get_module_eeprom(struct sfp_bus *bus, struct ethtool_eeprom *ee,
@@ -593,7 +593,7 @@ static inline void sfp_parse_support(struct sfp_bus *bus,
 }
 
 static inline phy_interface_t sfp_select_interface(struct sfp_bus *bus,
-                                                  unsigned long *link_modes)
+                                               const unsigned long *link_modes)
 {
        return PHY_INTERFACE_MODE_NA;
 }