drm/i915/display: Make POWER_DOMAIN_*() always result in enum intel_display_power_domain
authorGustavo Sousa <gustavo.sousa@intel.com>
Thu, 27 Feb 2025 21:09:13 +0000 (18:09 -0300)
committerGustavo Sousa <gustavo.sousa@intel.com>
Fri, 28 Feb 2025 16:30:57 +0000 (13:30 -0300)
In the hope of contributing to type safety in our code, let's ensure
that the type returned by the POWER_DOMAIN_*() macros is always of type
enum intel_display_power_domain.

v2:
  - Remove accidental +1 in definition of POWER_DOMAIN_PIPE(). (Jani)

Cc: Jani Nikula <jani.nikula@intel.com>
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20250227-improve-type-safey-power-domain-macros-v3-2-b6eaa00f9c33@intel.com
Signed-off-by: Gustavo Sousa <gustavo.sousa@intel.com>
drivers/gpu/drm/i915/display/intel_display_power.h

index 4ad35bd4b040f2fb0220376d443ad84ae2ecab48..1b53d67f9b60dea3eb6938b81ab483c0295c6ad3 100644 (file)
@@ -117,12 +117,13 @@ enum intel_display_power_domain {
        POWER_DOMAIN_INVALID = POWER_DOMAIN_NUM,
 };
 
-#define POWER_DOMAIN_PIPE(pipe) ((pipe) - PIPE_A + POWER_DOMAIN_PIPE_A)
+#define POWER_DOMAIN_PIPE(pipe) \
+       ((enum intel_display_power_domain)((pipe) - PIPE_A + POWER_DOMAIN_PIPE_A))
 #define POWER_DOMAIN_PIPE_PANEL_FITTER(pipe) \
-               ((pipe) - PIPE_A + POWER_DOMAIN_PIPE_PANEL_FITTER_A)
+       ((enum intel_display_power_domain)((pipe) - PIPE_A + POWER_DOMAIN_PIPE_PANEL_FITTER_A))
 #define POWER_DOMAIN_TRANSCODER(tran) \
        ((tran) == TRANSCODER_EDP ? POWER_DOMAIN_TRANSCODER_EDP : \
-        (tran) - TRANSCODER_A + POWER_DOMAIN_TRANSCODER_A)
+        (enum intel_display_power_domain)((tran) - TRANSCODER_A + POWER_DOMAIN_TRANSCODER_A))
 
 struct intel_power_domain_mask {
        DECLARE_BITMAP(bits, POWER_DOMAIN_NUM);