media: coda: move framebuffer size calculation out of loop
authorPhilipp Zabel <p.zabel@pengutronix.de>
Thu, 28 Jun 2018 10:57:52 +0000 (06:57 -0400)
committerMauro Carvalho Chehab <mchehab+samsung@kernel.org>
Wed, 25 Jul 2018 12:26:33 +0000 (08:26 -0400)
All internal YCbCr frame buffers are the same size, calculate ycbcr_size
once before the allocation loop.

Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
drivers/media/platform/coda/coda-bit.c

index 26d14e6a64ccb3d45f7c1934fc6cfcd5715ba38a..033abb03722b05c5c14f4fee9c29bfa5afbfe61e 100644 (file)
@@ -391,7 +391,7 @@ static int coda_alloc_framebuffers(struct coda_ctx *ctx,
 {
        struct coda_dev *dev = ctx->dev;
        int width, height;
-       int ysize;
+       unsigned int ysize, ycbcr_size;
        int ret;
        int i;
 
@@ -407,15 +407,16 @@ static int coda_alloc_framebuffers(struct coda_ctx *ctx,
        }
        ysize = width * height;
 
+       if (ctx->tiled_map_type == GDI_TILED_FRAME_MB_RASTER_MAP)
+               ycbcr_size = round_up(ysize, 4096) + ysize / 2;
+       else
+               ycbcr_size = ysize + ysize / 2;
+
        /* Allocate frame buffers */
        for (i = 0; i < ctx->num_internal_frames; i++) {
-               size_t size;
+               size_t size = ycbcr_size;
                char *name;
 
-               if (ctx->tiled_map_type == GDI_TILED_FRAME_MB_RASTER_MAP)
-                       size = round_up(ysize, 4096) + ysize / 2;
-               else
-                       size = ysize + ysize / 2;
                /* Add space for mvcol buffers */
                if (dev->devtype->product != CODA_DX6 &&
                    (ctx->codec->src_fourcc == V4L2_PIX_FMT_H264 ||