cpufreq: schedutil: fix equation in comment
authorQais Yousef <qais.yousef@arm.com>
Fri, 2 Aug 2019 10:46:28 +0000 (11:46 +0100)
committerPeter Zijlstra <peterz@infradead.org>
Thu, 8 Aug 2019 07:09:31 +0000 (09:09 +0200)
scale_irq_capacity() call in schedutil_cpu_util() does

util *= (max - irq)
util /= max

But the comment says

util *= (1 - irq)
util /= max

Fix the comment to match what the scaling function does.

Signed-off-by: Qais Yousef <qais.yousef@arm.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
Acked-by: Vincent Guittot <vincent.guittot@linaro.org>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: "Rafael J . Wysocki" <rjw@rjwysocki.net>
Link: https://lkml.kernel.org/r/20190802104628.8410-1-qais.yousef@arm.com
kernel/sched/cpufreq_schedutil.c

index 636ca6f88c8ee275efd664c553609c5121a5cb3f..e127d89d5974499bfbcba34e6d0a456c0d9ac6d3 100644 (file)
@@ -259,9 +259,9 @@ unsigned long schedutil_cpu_util(int cpu, unsigned long util_cfs,
         * irq metric. Because IRQ/steal time is hidden from the task clock we
         * need to scale the task numbers:
         *
-        *              1 - irq
-        *   U' = irq + ------- * U
-        *                max
+        *              max - irq
+        *   U' = irq + --------- * U
+        *                 max
         */
        util = scale_irq_capacity(util, irq, max);
        util += irq;