mtd: rawnand: fsl_elbc: convert driver to nand_scan()
authorMiquel Raynal <miquel.raynal@bootlin.com>
Wed, 25 Jul 2018 08:37:40 +0000 (10:37 +0200)
committerMiquel Raynal <miquel.raynal@bootlin.com>
Tue, 31 Jul 2018 07:45:57 +0000 (09:45 +0200)
Two helpers have been added to the core to do all kind of controller
side configuration/initialization between the detection phase and the
final NAND scan. Implement these hooks so that we can convert the driver
to just use nand_scan() instead of the nand_scan_ident() +
nand_scan_tail() pair.

Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
Reviewed-by: Boris Brezillon <boris.brezillon@bootlin.com>
Notes:
    "pw 947037"

drivers/mtd/nand/raw/fsl_elbc_nand.c

index b5637dce6d475295fe6a51eb3abb6c867346b74b..55f449b711fd9fc4ad8ff2fc68f35524f37a481a 100644 (file)
@@ -637,9 +637,9 @@ static int fsl_elbc_wait(struct mtd_info *mtd, struct nand_chip *chip)
        return (elbc_fcm_ctrl->mdr & 0xff) | NAND_STATUS_WP;
 }
 
-static int fsl_elbc_chip_init_tail(struct mtd_info *mtd)
+static int fsl_elbc_attach_chip(struct nand_chip *chip)
 {
-       struct nand_chip *chip = mtd_to_nand(mtd);
+       struct mtd_info *mtd = nand_to_mtd(chip);
        struct fsl_elbc_mtd *priv = nand_get_controller_data(chip);
        struct fsl_lbc_ctrl *ctrl = priv->ctrl;
        struct fsl_lbc_regs __iomem *lbc = ctrl->regs;
@@ -706,6 +706,10 @@ static int fsl_elbc_chip_init_tail(struct mtd_info *mtd)
        return 0;
 }
 
+static const struct nand_controller_ops fsl_elbc_controller_ops = {
+       .attach_chip = fsl_elbc_attach_chip,
+};
+
 static int fsl_elbc_read_page(struct mtd_info *mtd, struct nand_chip *chip,
                              uint8_t *buf, int oob_required, int page)
 {
@@ -910,15 +914,8 @@ static int fsl_elbc_nand_probe(struct platform_device *pdev)
        if (ret)
                goto err;
 
-       ret = nand_scan_ident(mtd, 1, NULL);
-       if (ret)
-               goto err;
-
-       ret = fsl_elbc_chip_init_tail(mtd);
-       if (ret)
-               goto err;
-
-       ret = nand_scan_tail(mtd);
+       priv->chip.controller->ops = &fsl_elbc_controller_ops;
+       ret = nand_scan(mtd, 1);
        if (ret)
                goto err;