net: core: dev: replace state xoff flag comparison by netif_xmit_stopped method
authorJulio Faracco <jcfaracco@gmail.com>
Tue, 1 Oct 2019 14:39:04 +0000 (11:39 -0300)
committerDavid S. Miller <davem@davemloft.net>
Tue, 1 Oct 2019 16:26:03 +0000 (09:26 -0700)
Function netif_schedule_queue() has a hardcoded comparison between queue
state and any xoff flag. This comparison does the same thing as method
netif_xmit_stopped(). In terms of code clarity, it is better. See other
methods like: generic_xdp_tx() and dev_direct_xmit().

Signed-off-by: Julio Faracco <jcfaracco@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/core/dev.c

index bf3ed413abafe121d8c20ea4ca023ea770c111cc..21a9c2987cbbafb0ad3f0962fa0b99b47c5b8898 100644 (file)
@@ -2771,7 +2771,7 @@ static struct dev_kfree_skb_cb *get_kfree_skb_cb(const struct sk_buff *skb)
 void netif_schedule_queue(struct netdev_queue *txq)
 {
        rcu_read_lock();
-       if (!(txq->state & QUEUE_STATE_ANY_XOFF)) {
+       if (!netif_xmit_stopped(txq)) {
                struct Qdisc *q = rcu_dereference(txq->qdisc);
 
                __netif_schedule(q);