drm/msm/disp/dpu1: add safe lut config in dpu driver
authorKalyan Thota <kalyan_t@codeaurora.org>
Wed, 4 Aug 2021 09:40:28 +0000 (02:40 -0700)
committerRob Clark <robdclark@chromium.org>
Sat, 7 Aug 2021 18:48:40 +0000 (11:48 -0700)
Add safe lut configuration for all the targets in dpu
driver as per QOS recommendation.

Issue reported on SC7280:

With wait-for-safe feature in smmu enabled, RT client
buffer levels are checked to be safe before smmu invalidation.
Since display was always set to unsafe it was delaying the
invalidaiton process thus impacting the performance on NRT clients
such as eMMC and NVMe.

Validated this change on SC7280, With this change eMMC performance
has improved significantly.

Changes in v2:
- Add fixes tag (Sai)
- CC stable kernel (Dimtry)

Changes in v3:
- Correct fixes tag with appropriate hash (stephen)
- Resend patch adding reviewed by tag
- Resend patch adding correct format for pushing into stable tree (Greg)

Fixes: 591e34a091d1 ("drm/msm/disp/dpu1: add support for display for SC7280 target")
Cc: stable@vger.kernel.org
Signed-off-by: Kalyan Thota <kalyan_t@codeaurora.org>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Tested-by: Sai Prakash Ranjan <saiprakash.ranjan@codeaurora.org> (sc7280, sc7180)
Link: https://lore.kernel.org/r/1628070028-2616-1-git-send-email-kalyan_t@codeaurora.org
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Signed-off-by: Rob Clark <robdclark@chromium.org>
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c

index d01c4c919504315d8460f839d83f3c9cd2082a73..2e482cdd7b3c51a189d3c4ceb4b6a8852f607635 100644 (file)
@@ -974,6 +974,7 @@ static const struct dpu_perf_cfg sdm845_perf_data = {
        .amortizable_threshold = 25,
        .min_prefill_lines = 24,
        .danger_lut_tbl = {0xf, 0xffff, 0x0},
+       .safe_lut_tbl = {0xfff0, 0xf000, 0xffff},
        .qos_lut_tbl = {
                {.nentry = ARRAY_SIZE(sdm845_qos_linear),
                .entries = sdm845_qos_linear
@@ -1001,6 +1002,7 @@ static const struct dpu_perf_cfg sc7180_perf_data = {
        .min_dram_ib = 1600000,
        .min_prefill_lines = 24,
        .danger_lut_tbl = {0xff, 0xffff, 0x0},
+       .safe_lut_tbl = {0xfff0, 0xff00, 0xffff},
        .qos_lut_tbl = {
                {.nentry = ARRAY_SIZE(sc7180_qos_linear),
                .entries = sc7180_qos_linear
@@ -1028,6 +1030,7 @@ static const struct dpu_perf_cfg sm8150_perf_data = {
        .min_dram_ib = 800000,
        .min_prefill_lines = 24,
        .danger_lut_tbl = {0xf, 0xffff, 0x0},
+       .safe_lut_tbl = {0xfff8, 0xf000, 0xffff},
        .qos_lut_tbl = {
                {.nentry = ARRAY_SIZE(sm8150_qos_linear),
                .entries = sm8150_qos_linear
@@ -1056,6 +1059,7 @@ static const struct dpu_perf_cfg sm8250_perf_data = {
        .min_dram_ib = 800000,
        .min_prefill_lines = 35,
        .danger_lut_tbl = {0xf, 0xffff, 0x0},
+       .safe_lut_tbl = {0xfff0, 0xff00, 0xffff},
        .qos_lut_tbl = {
                {.nentry = ARRAY_SIZE(sc7180_qos_linear),
                .entries = sc7180_qos_linear
@@ -1084,6 +1088,7 @@ static const struct dpu_perf_cfg sc7280_perf_data = {
        .min_dram_ib = 1600000,
        .min_prefill_lines = 24,
        .danger_lut_tbl = {0xffff, 0xffff, 0x0},
+       .safe_lut_tbl = {0xff00, 0xff00, 0xffff},
        .qos_lut_tbl = {
                {.nentry = ARRAY_SIZE(sc7180_qos_macrotile),
                .entries = sc7180_qos_macrotile