tracing/uprobe: Drop isdigit() check in create_trace_uprobe
authorDmitry Safonov <dsafonov@virtuozzo.com>
Thu, 25 Aug 2016 15:21:09 +0000 (18:21 +0300)
committerSteven Rostedt <rostedt@goodmis.org>
Thu, 1 Sep 2016 15:18:09 +0000 (11:18 -0400)
It's useless. Before:
  [tracing]# echo 'p:test /a:0x0' >> uprobe_events
  [tracing]# echo 'p:test a:0x0' >> uprobe_events
  -bash: echo: write error: No such file or directory
  [tracing]# echo 'p:test 1:0x0' >> uprobe_events
  -bash: echo: write error: Invalid argument

After:
  [tracing]# echo 'p:test 1:0x0' >> uprobe_events
  -bash: echo: write error: No such file or directory

Link: http://lkml.kernel.org/r/20160825152110.25663-3-dsafonov@virtuozzo.com
Acked-by: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
Acked-by: Oleg Nesterov <oleg@redhat.com>
Signed-off-by: Dmitry Safonov <dsafonov@virtuozzo.com>
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
kernel/trace/trace_uprobe.c

index c53485441c88ad142cbab7bb7edfd4e5139832d1..a74f2d9ff37956061eae2e5b6ebb6aea71e25f60 100644 (file)
@@ -427,10 +427,6 @@ static int create_trace_uprobe(int argc, char **argv)
                pr_info("Probe point is not specified.\n");
                return -EINVAL;
        }
-       if (isdigit(argv[1][0])) {
-               pr_info("probe point must be have a filename.\n");
-               return -EINVAL;
-       }
        arg = strchr(argv[1], ':');
        if (!arg) {
                ret = -EINVAL;