drm/amd/display: dc_link: code clean up on detect_dp function
authorMelissa Wen <melissa.srw@gmail.com>
Fri, 28 Feb 2020 16:43:19 +0000 (13:43 -0300)
committerAlex Deucher <alexander.deucher@amd.com>
Thu, 5 Mar 2020 05:27:30 +0000 (00:27 -0500)
Removes codestyle issues on detect_dp function as suggested by
checkpatch.pl.

CHECK: Lines should not end with a '('
WARNING: Missing a blank line after declarations
WARNING: line over 80 characters
CHECK: Alignment should match open parenthesis

Signed-off-by: Melissa Wen <melissa.srw@gmail.com>
Reviewed-by: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>
Reviewed-by: Zhan Liu <zhan.liu@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/display/dc/core/dc_link.c

index eb9894e416ed00c1c7b5a3af96a75583898adfd9..549bea1d725c559e17af1e3fdbae2e26d9bbcc7a 100644 (file)
@@ -585,14 +585,14 @@ static void read_current_link_settings_on_detect(struct dc_link *link)
                LINK_SPREAD_05_DOWNSPREAD_30KHZ : LINK_SPREAD_DISABLED;
 }
 
-static bool detect_dp(
-       struct dc_link *link,
-       struct display_sink_capability *sink_caps,
-       bool *converter_disable_audio,
-       struct audio_support *audio_support,
-       enum dc_detect_reason reason)
+static bool detect_dp(struct dc_link *link,
+                     struct display_sink_capability *sink_caps,
+                     bool *converter_disable_audio,
+                     struct audio_support *audio_support,
+                     enum dc_detect_reason reason)
 {
        bool boot = false;
+
        sink_caps->signal = link_detect_sink(link, reason);
        sink_caps->transaction_type =
                get_ddc_transaction_type(sink_caps->signal);
@@ -609,9 +609,8 @@ static bool detect_dp(
                        sink_caps->signal = SIGNAL_TYPE_DISPLAY_PORT_MST;
                        link->type = dc_connection_mst_branch;
 
-                       dal_ddc_service_set_transaction_type(
-                                                       link->ddc,
-                                                       sink_caps->transaction_type);
+                       dal_ddc_service_set_transaction_type(link->ddc,
+                                                            sink_caps->transaction_type);
 
                        /*
                         * This call will initiate MST topology discovery. Which
@@ -640,13 +639,10 @@ static bool detect_dp(
                        if (reason == DETECT_REASON_BOOT)
                                boot = true;
 
-                       dm_helpers_dp_update_branch_info(
-                               link->ctx,
-                               link);
+                       dm_helpers_dp_update_branch_info(link->ctx, link);
 
-                       if (!dm_helpers_dp_mst_start_top_mgr(
-                               link->ctx,
-                               link, boot)) {
+                       if (!dm_helpers_dp_mst_start_top_mgr(link->ctx,
+                                                            link, boot)) {
                                /* MST not supported */
                                link->type = dc_connection_single;
                                sink_caps->signal = SIGNAL_TYPE_DISPLAY_PORT;
@@ -654,7 +650,7 @@ static bool detect_dp(
                }
 
                if (link->type != dc_connection_mst_branch &&
-                       is_dp_active_dongle(link)) {
+                   is_dp_active_dongle(link)) {
                        /* DP active dongles */
                        link->type = dc_connection_active_dongle;
                        if (!link->dpcd_caps.sink_count.bits.SINK_COUNT) {
@@ -665,14 +661,15 @@ static bool detect_dp(
                                return true;
                        }
 
-                       if (link->dpcd_caps.dongle_type != DISPLAY_DONGLE_DP_HDMI_CONVERTER)
+                       if (link->dpcd_caps.dongle_type !=
+                           DISPLAY_DONGLE_DP_HDMI_CONVERTER)
                                *converter_disable_audio = true;
                }
        } else {
                /* DP passive dongles */
                sink_caps->signal = dp_passive_dongle_detection(link->ddc,
-                               sink_caps,
-                               audio_support);
+                                                               sink_caps,
+                                                               audio_support);
        }
 
        return true;