mmc: tmio: no magic values when enabling DMA
authorWolfram Sang <wsa+renesas@sang-engineering.com>
Fri, 30 Jun 2017 10:56:48 +0000 (12:56 +0200)
committerUlf Hansson <ulf.hansson@linaro.org>
Wed, 30 Aug 2017 12:01:25 +0000 (14:01 +0200)
Use a proper define.

Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
drivers/mmc/host/renesas_sdhi_core.c
drivers/mmc/host/tmio_mmc.h

index 569bcdd5e6537a3577bfe233d523512d027fbda4..c8d83faac00424317fa87bb15e6d84cb43ff60fa 100644 (file)
@@ -452,7 +452,7 @@ static int renesas_sdhi_multi_io_quirk(struct mmc_card *card,
 
 static void renesas_sdhi_enable_dma(struct tmio_mmc_host *host, bool enable)
 {
-       sd_ctrl_write16(host, CTL_DMA_ENABLE, enable ? 2 : 0);
+       sd_ctrl_write16(host, CTL_DMA_ENABLE, enable ? DMA_ENABLE_DMASDRW : 0);
 
        /* enable 32bit access if DMA mode if possibile */
        renesas_sdhi_sdbuf_width(host, enable ? 32 : 16);
index e3e96178acaab4562cb0858c5c8aa2e47ef36abd..3e6ff89214403495844427cc95efd4e646604e4d 100644 (file)
@@ -97,6 +97,9 @@
 
 #define TMIO_SDIO_SETBITS_MASK 0x0006
 
+/* Definitions for values the CTL_DMA_ENABLE register can take */
+#define DMA_ENABLE_DMASDRW     BIT(1)
+
 /* Define some IRQ masks */
 /* This is the mask used at reset by the chip */
 #define TMIO_MASK_ALL           0x837f031d