[media] cx231xx: stray unlock on error path
authorDan Carpenter <error27@gmail.com>
Thu, 18 Nov 2010 03:56:37 +0000 (00:56 -0300)
committerMauro Carvalho Chehab <mchehab@redhat.com>
Wed, 29 Dec 2010 10:16:57 +0000 (08:16 -0200)
The lock isn't held here and doesn't need to be unlocked.  The code has
been like this since the driver was merged.

Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
drivers/media/video/cx231xx/cx231xx-cards.c

index 2b61017633551e8a5d618685abb7c2ffc3bbb666..61756502c085b6a3fbfd173eccc78d9f4cf0c379 100644 (file)
@@ -784,7 +784,7 @@ static int cx231xx_init_dev(struct cx231xx **devhandle, struct usb_device *udev,
        retval = cx231xx_register_analog_devices(dev);
        if (retval < 0) {
                cx231xx_release_resources(dev);
-               goto fail_reg_devices;
+               return retval;
        }
 
        cx231xx_ir_init(dev);
@@ -792,10 +792,6 @@ static int cx231xx_init_dev(struct cx231xx **devhandle, struct usb_device *udev,
        cx231xx_init_extension(dev);
 
        return 0;
-
-fail_reg_devices:
-       mutex_unlock(&dev->lock);
-       return retval;
 }
 
 #if defined(CONFIG_MODULES) && defined(MODULE)