net/ena: reduce the severity of ena printouts
authorNetanel Belgazal <netanel@annapurnalabs.com>
Thu, 9 Feb 2017 13:21:36 +0000 (15:21 +0200)
committerDavid S. Miller <davem@davemloft.net>
Fri, 10 Feb 2017 03:27:06 +0000 (22:27 -0500)
Signed-off-by: Netanel Belgazal <netanel@annapurnalabs.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/amazon/ena/ena_com.c
drivers/net/ethernet/amazon/ena/ena_netdev.c

index 46aad3a4f6e3663de729bfb3fa942661551dae07..5518b1f2fe423532bfaf06cb1a0ba323f34d3e40 100644 (file)
@@ -784,7 +784,7 @@ static int ena_com_get_feature_ex(struct ena_com_dev *ena_dev,
        int ret;
 
        if (!ena_com_check_supported_feature_id(ena_dev, feature_id)) {
-               pr_info("Feature %d isn't supported\n", feature_id);
+               pr_debug("Feature %d isn't supported\n", feature_id);
                return -EPERM;
        }
 
@@ -1126,7 +1126,13 @@ int ena_com_execute_admin_command(struct ena_com_admin_queue *admin_queue,
        comp_ctx = ena_com_submit_admin_cmd(admin_queue, cmd, cmd_size,
                                            comp, comp_size);
        if (unlikely(IS_ERR(comp_ctx))) {
-               pr_err("Failed to submit command [%ld]\n", PTR_ERR(comp_ctx));
+               if (comp_ctx == ERR_PTR(-ENODEV))
+                       pr_debug("Failed to submit command [%ld]\n",
+                                PTR_ERR(comp_ctx));
+               else
+                       pr_err("Failed to submit command [%ld]\n",
+                              PTR_ERR(comp_ctx));
+
                return PTR_ERR(comp_ctx);
        }
 
@@ -1895,7 +1901,7 @@ int ena_com_set_dev_mtu(struct ena_com_dev *ena_dev, int mtu)
        int ret;
 
        if (!ena_com_check_supported_feature_id(ena_dev, ENA_ADMIN_MTU)) {
-               pr_info("Feature %d isn't supported\n", ENA_ADMIN_MTU);
+               pr_debug("Feature %d isn't supported\n", ENA_ADMIN_MTU);
                return -EPERM;
        }
 
@@ -1948,8 +1954,8 @@ int ena_com_set_hash_function(struct ena_com_dev *ena_dev)
 
        if (!ena_com_check_supported_feature_id(ena_dev,
                                                ENA_ADMIN_RSS_HASH_FUNCTION)) {
-               pr_info("Feature %d isn't supported\n",
-                       ENA_ADMIN_RSS_HASH_FUNCTION);
+               pr_debug("Feature %d isn't supported\n",
+                        ENA_ADMIN_RSS_HASH_FUNCTION);
                return -EPERM;
        }
 
@@ -2112,7 +2118,8 @@ int ena_com_set_hash_ctrl(struct ena_com_dev *ena_dev)
 
        if (!ena_com_check_supported_feature_id(ena_dev,
                                                ENA_ADMIN_RSS_HASH_INPUT)) {
-               pr_info("Feature %d isn't supported\n", ENA_ADMIN_RSS_HASH_INPUT);
+               pr_debug("Feature %d isn't supported\n",
+                        ENA_ADMIN_RSS_HASH_INPUT);
                return -EPERM;
        }
 
@@ -2270,8 +2277,8 @@ int ena_com_indirect_table_set(struct ena_com_dev *ena_dev)
 
        if (!ena_com_check_supported_feature_id(
                    ena_dev, ENA_ADMIN_RSS_REDIRECTION_TABLE_CONFIG)) {
-               pr_info("Feature %d isn't supported\n",
-                       ENA_ADMIN_RSS_REDIRECTION_TABLE_CONFIG);
+               pr_debug("Feature %d isn't supported\n",
+                        ENA_ADMIN_RSS_REDIRECTION_TABLE_CONFIG);
                return -EPERM;
        }
 
@@ -2542,8 +2549,8 @@ int ena_com_init_interrupt_moderation(struct ena_com_dev *ena_dev)
 
        if (rc) {
                if (rc == -EPERM) {
-                       pr_info("Feature %d isn't supported\n",
-                               ENA_ADMIN_INTERRUPT_MODERATION);
+                       pr_debug("Feature %d isn't supported\n",
+                                ENA_ADMIN_INTERRUPT_MODERATION);
                        rc = 0;
                } else {
                        pr_err("Failed to get interrupt moderation admin cmd. rc: %d\n",
index d467a7914dd0abf93980b6ec22b8831fae850376..50793665707c0e51258c7285e499a4e3336ad71d 100644 (file)
@@ -563,6 +563,7 @@ static void ena_free_all_rx_bufs(struct ena_adapter *adapter)
  */
 static void ena_free_tx_bufs(struct ena_ring *tx_ring)
 {
+       bool print_once = true;
        u32 i;
 
        for (i = 0; i < tx_ring->ring_size; i++) {
@@ -574,9 +575,16 @@ static void ena_free_tx_bufs(struct ena_ring *tx_ring)
                if (!tx_info->skb)
                        continue;
 
-               netdev_notice(tx_ring->netdev,
-                             "free uncompleted tx skb qid %d idx 0x%x\n",
-                             tx_ring->qid, i);
+               if (print_once) {
+                       netdev_notice(tx_ring->netdev,
+                                     "free uncompleted tx skb qid %d idx 0x%x\n",
+                                     tx_ring->qid, i);
+                       print_once = false;
+               } else {
+                       netdev_dbg(tx_ring->netdev,
+                                  "free uncompleted tx skb qid %d idx 0x%x\n",
+                                  tx_ring->qid, i);
+               }
 
                ena_buf = tx_info->bufs;
                dma_unmap_single(tx_ring->dev,