USB: gadget: pxa25x: Re-use DEFINE_SHOW_ATTRIBUTE() macro

...instead of open coding file operations followed by custom ->open()
callbacks per each attribute.

Cc: Daniel Mack <daniel@zonque.org>
Cc: Haojian Zhuang <haojian.zhuang@gmail.com>
Cc: Robert Jarzmik <robert.jarzmik@free.fr>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Felipe Balbi <felipe.balbi@linux.intel.com>

diff --git a/drivers/usb/gadget/udc/pxa25x_udc.c b/drivers/usb/gadget/udc/pxa25x_udc.c
index 0e3f5faa000e93cca3349930111ea0072ed7989b..d4be53559f2e160ec9e37f49641e07c1ba45ff2e 100644 (file)
--- a/drivers/usb/gadget/udc/pxa25x_udc.c
+++ b/drivers/usb/gadget/udc/pxa25x_udc.c
@@ -1233,8 +1233,7 @@ static const struct usb_gadget_ops pxa25x_udc_ops = {
 
 #ifdef CONFIG_USB_GADGET_DEBUG_FS
 
-static int
-udc_seq_show(struct seq_file *m, void *_d)
+static int udc_debug_show(struct seq_file *m, void *_d)
 {
        struct pxa25x_udc       *dev = m->private;
        unsigned long           flags;
@@ -1335,25 +1334,12 @@ done:
        local_irq_restore(flags);
        return 0;
 }
-
-static int
-udc_debugfs_open(struct inode *inode, struct file *file)
-{
-       return single_open(file, udc_seq_show, inode->i_private);
-}
-
-static const struct file_operations debug_fops = {
-       .open           = udc_debugfs_open,
-       .read           = seq_read,
-       .llseek         = seq_lseek,
-       .release        = single_release,
-       .owner          = THIS_MODULE,
-};
+DEFINE_SHOW_ATTRIBUTE(udc_debug);
 
 #define create_debug_files(dev) \
        do { \
                dev->debugfs_udc = debugfs_create_file(dev->gadget.name, \
-                       S_IRUGO, NULL, dev, &debug_fops); \
+                       S_IRUGO, NULL, dev, &udc_debug_fops); \
        } while (0)
 #define remove_debug_files(dev) debugfs_remove(dev->debugfs_udc)