i2c: ocores: set IACK bit after core is enabled
authorGrygorii Tertychnyi <grembeter@gmail.com>
Mon, 20 May 2024 15:39:32 +0000 (17:39 +0200)
committerAndi Shyti <andi.shyti@kernel.org>
Thu, 20 Jun 2024 23:17:43 +0000 (01:17 +0200)
Setting IACK bit when core is disabled does not clear the "Interrupt Flag"
bit in the status register, and the interrupt remains pending.

Sometimes it causes failure for the very first message transfer, that is
usually a device probe.

Hence, set IACK bit after core is enabled to clear pending interrupt.

Fixes: 18f98b1e3147 ("[PATCH] i2c: New bus driver for the OpenCores I2C controller")
Signed-off-by: Grygorii Tertychnyi <grygorii.tertychnyi@leica-geosystems.com>
Acked-by: Peter Korsgaard <peter@korsgaard.com>
Cc: stable@vger.kernel.org
Signed-off-by: Andi Shyti <andi.shyti@kernel.org>
drivers/i2c/busses/i2c-ocores.c

index 56a4dabf5a388788ba488b2473d642093706cb24..4ad670a80a63af7b1d5be98c2886757b85545e5e 100644 (file)
@@ -431,8 +431,8 @@ static int ocores_init(struct device *dev, struct ocores_i2c *i2c)
        oc_setreg(i2c, OCI2C_PREHIGH, prescale >> 8);
 
        /* Init the device */
-       oc_setreg(i2c, OCI2C_CMD, OCI2C_CMD_IACK);
        oc_setreg(i2c, OCI2C_CONTROL, ctrl | OCI2C_CTRL_EN);
+       oc_setreg(i2c, OCI2C_CMD, OCI2C_CMD_IACK);
 
        return 0;
 }