watchdog: iTCO_wdt: Remove unused hooks
authorJean Delvare <jdelvare@suse.de>
Fri, 31 Aug 2018 13:07:34 +0000 (15:07 +0200)
committerWim Van Sebroeck <wim@linux-watchdog.org>
Tue, 2 Oct 2018 11:32:25 +0000 (13:32 +0200)
As the only user of iTCO_vendor_pre_keepalive and
iTCO_vendor_pre_set_heartbeat has just been removed, we can delete
these 2 hooks.

Signed-off-by: Jean Delvare <jdelvare@suse.de>
Cc: Martin Wilck <mwilck@suse.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Wim Van Sebroeck <wim@linux-watchdog.org>
drivers/watchdog/iTCO_vendor.h
drivers/watchdog/iTCO_vendor_support.c
drivers/watchdog/iTCO_wdt.c

index 7b82a7c6e7c39ee20e1eb3e5fd96172ccecb885b..0f7373ba10d5be065811e429fce8b93f71a2ef4f 100644 (file)
@@ -3,14 +3,10 @@
 #ifdef CONFIG_ITCO_VENDOR_SUPPORT
 extern void iTCO_vendor_pre_start(struct resource *, unsigned int);
 extern void iTCO_vendor_pre_stop(struct resource *);
-extern void iTCO_vendor_pre_keepalive(struct resource *, unsigned int);
-extern void iTCO_vendor_pre_set_heartbeat(unsigned int);
 extern int iTCO_vendor_check_noreboot_on(void);
 #else
 #define iTCO_vendor_pre_start(acpibase, heartbeat)     {}
 #define iTCO_vendor_pre_stop(acpibase)                 {}
-#define iTCO_vendor_pre_keepalive(acpibase, heartbeat) {}
-#define iTCO_vendor_pre_set_heartbeat(heartbeat)       {}
 #define iTCO_vendor_check_noreboot_on()                        1
                                /* 1=check noreboot; 0=don't check */
 #endif
index d714a06de57c291bc57916425894456d87c09736..68a9d9cc2eb8337a8c7edb498083acc9f37ec29a 100644 (file)
@@ -180,16 +180,6 @@ void iTCO_vendor_pre_stop(struct resource *smires)
 }
 EXPORT_SYMBOL(iTCO_vendor_pre_stop);
 
-void iTCO_vendor_pre_keepalive(struct resource *smires, unsigned int heartbeat)
-{
-}
-EXPORT_SYMBOL(iTCO_vendor_pre_keepalive);
-
-void iTCO_vendor_pre_set_heartbeat(unsigned int heartbeat)
-{
-}
-EXPORT_SYMBOL(iTCO_vendor_pre_set_heartbeat);
-
 int iTCO_vendor_check_noreboot_on(void)
 {
        switch (vendorsupport) {
index 347f0389b0899d4183021254203e0a0938600267..0a5318b7865e35660f47f78ce73864846f0de55d 100644 (file)
@@ -304,8 +304,6 @@ static int iTCO_wdt_ping(struct watchdog_device *wd_dev)
 
        spin_lock(&p->io_lock);
 
-       iTCO_vendor_pre_keepalive(p->smi_res, wd_dev->timeout);
-
        /* Reload the timer by writing to the TCO Timer Counter register */
        if (p->iTCO_version >= 2) {
                outw(0x01, TCO_RLD(p));
@@ -342,8 +340,6 @@ static int iTCO_wdt_set_timeout(struct watchdog_device *wd_dev, unsigned int t)
            (p->iTCO_version == 1 && tmrval > 0x03f))
                return -EINVAL;
 
-       iTCO_vendor_pre_set_heartbeat(tmrval);
-
        /* Write new heartbeat to watchdog */
        if (p->iTCO_version >= 2) {
                spin_lock(&p->io_lock);