gfs2: Remove ill-placed consistency check
authorAndreas Gruenbacher <agruenba@redhat.com>
Wed, 10 Apr 2024 02:24:56 +0000 (04:24 +0200)
committerAndreas Gruenbacher <agruenba@redhat.com>
Wed, 24 Apr 2024 17:48:20 +0000 (19:48 +0200)
This consistency check was originally added by commit 9287c6452d2b1
("gfs2: Fix occasional glock use-after-free").  It is ill-placed in
gfs2_glock_free() because if it holds there, it must equally hold in
__gfs2_glock_put() already.  Either way, the check doesn't seem
necessary anymore.

Signed-off-by: Andreas Gruenbacher <agruenba@redhat.com>
fs/gfs2/glock.c

index 8e6936b794605eb72eea64175086de3fbc56b7e8..bf7538274985cbf1e3aefb31469624edccc80bae 100644 (file)
@@ -170,7 +170,6 @@ void gfs2_glock_free(struct gfs2_glock *gl)
 {
        struct gfs2_sbd *sdp = gl->gl_name.ln_sbd;
 
-       gfs2_glock_assert_withdraw(gl, atomic_read(&gl->gl_revokes) == 0);
        rhashtable_remove_fast(&gl_hash_table, &gl->gl_node, ht_parms);
        smp_mb();
        wake_up_glock(gl);