usb: xhci: Don't log transfer ring segment list on errors
authorMichal Pecio <michal.pecio@gmail.com>
Thu, 15 May 2025 13:55:58 +0000 (16:55 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 21 May 2025 10:35:31 +0000 (12:35 +0200)
The error message above used to span two lines, rarely more. A recent
cleanup concentrated useful information from it in one line, but then
it added printing the list of all ring segments, which is even longer
than before. It provides no new information in usual cases and little
in unusual ones, but adds noise to the log. Drop it.

Signed-off-by: Michal Pecio <michal.pecio@gmail.com>
Signed-off-by: Mathias Nyman <mathias.nyman@linux.intel.com>
Link: https://lore.kernel.org/r/20250515135621.335595-2-mathias.nyman@linux.intel.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/host/xhci-ring.c

index eefbc7b3681e1b17407842c6f917de1bf77e29c7..1d52682953962b36e5530293ef2f7a4a31954372 100644 (file)
@@ -2977,9 +2977,6 @@ debug_finding_td:
                 (unsigned long long)xhci_trb_virt_to_dma(td->start_seg, td->start_trb),
                 (unsigned long long)xhci_trb_virt_to_dma(td->end_seg, td->end_trb));
 
-       xhci_for_each_ring_seg(ep_ring->first_seg, ep_seg)
-               xhci_warn(xhci, "Ring seg %u dma %pad\n", ep_seg->num, &ep_seg->dma);
-
        return -ESHUTDOWN;
 
 err_out: