modpost: zero-pad CRC values in modversion_info array
authorMasahiro Yamada <masahiroy@kernel.org>
Sat, 28 Dec 2024 15:45:29 +0000 (00:45 +0900)
committerMasahiro Yamada <masahiroy@kernel.org>
Fri, 10 Jan 2025 14:01:22 +0000 (23:01 +0900)
I do not think the '#' flag is useful here because adding the explicit
'0x' is clearer. Add the '0' flag to zero-pad the CRC values.

This change gives better alignment in the generated *.mod.c files.
There is no impact to the compiled modules.

[Before]

  $ grep -A5 modversion_info fs/efivarfs/efivarfs.mod.c
  static const struct modversion_info ____versions[]
  __used __section("__versions") = {
          { 0x907d14d, "blocking_notifier_chain_register" },
          { 0x53d3b64, "simple_inode_init_ts" },
          { 0x65487097, "__x86_indirect_thunk_rax" },
          { 0x122c3a7e, "_printk" },

[After]

  $ grep -A5 modversion_info fs/efivarfs/efivarfs.mod.c
  static const struct modversion_info ____versions[]
  __used __section("__versions") = {
          { 0x0907d14d, "blocking_notifier_chain_register" },
          { 0x053d3b64, "simple_inode_init_ts" },
          { 0x65487097, "__x86_indirect_thunk_rax" },
          { 0x122c3a7e, "_printk" },

Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
scripts/mod/modpost.c

index 7ea59dc4926b389b5431f81a13b2d8a0704f6153..dc907014108bb356f15fbf62c127a984728285b0 100644 (file)
@@ -1832,7 +1832,7 @@ static void add_versions(struct buffer *b, struct module *mod)
                              s->name, mod->name);
                        break;
                }
-               buf_printf(b, "\t{ %#8x, \"%s\" },\n",
+               buf_printf(b, "\t{ 0x%08x, \"%s\" },\n",
                           s->crc, s->name);
        }