wifi: ath12k: fix BSS chan info request WMI command
authorP Praneesh <quic_ppranees@quicinc.com>
Sun, 31 Mar 2024 18:32:31 +0000 (00:02 +0530)
committerKalle Valo <quic_kvalo@quicinc.com>
Wed, 7 Aug 2024 08:12:13 +0000 (11:12 +0300)
Currently, the firmware returns incorrect pdev_id information in
WMI_PDEV_BSS_CHAN_INFO_EVENTID, leading to incorrect filling of
the pdev's survey information.

To prevent this issue, when requesting BSS channel information
through WMI_PDEV_BSS_CHAN_INFO_REQUEST_CMDID, firmware expects
pdev_id as one of the arguments in this WMI command.

Add pdev_id to the struct wmi_pdev_bss_chan_info_req_cmd and fill it
during ath12k_wmi_pdev_bss_chan_info_request(). This resolves the
issue of sending the correct pdev_id in WMI_PDEV_BSS_CHAN_INFO_EVENTID.

Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.0.1-00029-QCAHKSWPL_SILICONZ-1

Fixes: d889913205cf ("wifi: ath12k: driver for Qualcomm Wi-Fi 7 devices")
Signed-off-by: P Praneesh <quic_ppranees@quicinc.com>
Signed-off-by: Karthikeyan Kathirvel <quic_kathirve@quicinc.com>
Acked-by: Jeff Johnson <quic_jjohnson@quicinc.com>
Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com>
Link: https://patch.msgid.link/20240331183232.2158756-2-quic_kathirve@quicinc.com
drivers/net/wireless/ath/ath12k/wmi.c
drivers/net/wireless/ath/ath12k/wmi.h

index 9f6be557365e906de05a8f73abca6a79348b8301..a76413320dbf2f5f854c544506938e674ac65d8f 100644 (file)
@@ -1538,6 +1538,7 @@ int ath12k_wmi_pdev_bss_chan_info_request(struct ath12k *ar,
        cmd->tlv_header = ath12k_wmi_tlv_cmd_hdr(WMI_TAG_PDEV_BSS_CHAN_INFO_REQUEST,
                                                 sizeof(*cmd));
        cmd->req_type = cpu_to_le32(type);
+       cmd->pdev_id = cpu_to_le32(ar->pdev->pdev_id);
 
        ath12k_dbg(ar->ab, ATH12K_DBG_WMI,
                   "WMI bss chan info req type %d\n", type);
index f1f52175a52b3307a89fda5b616fc3b4c0032f28..9f4c2f026b4c1abe379827ae1d7165af57130dd1 100644 (file)
@@ -3121,6 +3121,7 @@ struct wmi_pdev_bss_chan_info_req_cmd {
        __le32 tlv_header;
        /* ref wmi_bss_chan_info_req_type */
        __le32 req_type;
+       __le32 pdev_id;
 } __packed;
 
 struct wmi_ap_ps_peer_cmd {