projects
/
linux-block.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
a0c8be5
)
net: ethernet: mvneta: Fix error handling in mvneta_probe
author
Dinghao Liu
<dinghao.liu@zju.edu.cn>
Sun, 20 Dec 2020 08:29:30 +0000
(16:29 +0800)
committer
Jakub Kicinski
<kuba@kernel.org>
Wed, 23 Dec 2020 02:49:45 +0000
(18:49 -0800)
When mvneta_port_power_up() fails, we should execute
cleanup functions after label err_netdev to avoid memleak.
Fixes:
41c2b6b4f0f80
("net: ethernet: mvneta: Add back interface mode validation")
Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn>
Link:
https://lore.kernel.org/r/20201220082930.21623-1-dinghao.liu@zju.edu.cn
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/marvell/mvneta.c
patch
|
blob
|
blame
|
history
diff --git
a/drivers/net/ethernet/marvell/mvneta.c
b/drivers/net/ethernet/marvell/mvneta.c
index 563ceac3060f9364333f62229c388660f00bdefa..3369ec717a51c83192ed6baca132742950eb7b80 100644
(file)
--- a/
drivers/net/ethernet/marvell/mvneta.c
+++ b/
drivers/net/ethernet/marvell/mvneta.c
@@
-5255,7
+5255,7
@@
static int mvneta_probe(struct platform_device *pdev)
err = mvneta_port_power_up(pp, pp->phy_interface);
if (err < 0) {
dev_err(&pdev->dev, "can't power up port\n");
-
return err
;
+
goto err_netdev
;
}
/* Armada3700 network controller does not support per-cpu