drm/amdgpu: fix a memory leak in amdgpu_ras_feature_enable
authorCong Liu <liucong2@kylinos.cn>
Thu, 14 Sep 2023 09:45:33 +0000 (17:45 +0800)
committerAlex Deucher <alexander.deucher@amd.com>
Wed, 20 Sep 2023 20:24:07 +0000 (16:24 -0400)
This patch fixes a memory leak in the amdgpu_ras_feature_enable() function.
The leak occurs when the function sends a command to the firmware to enable
or disable a RAS feature for a GFX block. If the command fails, the kfree()
function is not called to free the info memory.

Fixes: 9f051d6ff13f ("drm/amdgpu: Free ras cmd input buffer properly")
Reviewed-by: Hawking Zhang <Hawking.Zhang@amd.com>
Signed-off-by: Cong Liu <liucong2@kylinos.cn>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c

index 4e4ba2149595b80d43694cbfd841cb72ecec8d17..62dca5d80fb6e0d7542127ffdbf45fce9558cfe3 100644 (file)
@@ -802,6 +802,7 @@ int amdgpu_ras_feature_enable(struct amdgpu_device *adev,
                                enable ? "enable":"disable",
                                get_ras_block_str(head),
                                amdgpu_ras_is_poison_mode_supported(adev), ret);
+                       kfree(info);
                        return ret;
                }