hwmon: (max6621) Inverted if condition in max6621_read()
authorDan Carpenter <dan.carpenter@oracle.com>
Tue, 24 Oct 2017 09:47:42 +0000 (12:47 +0300)
committerGuenter Roeck <linux@roeck-us.net>
Mon, 30 Oct 2017 01:36:03 +0000 (18:36 -0700)
We intended to test for failure here but accidentally tested for
success.  It means that we don't set "*val" to true and it means that
if i2c_smbus_write_byte() does fail then we return success.

Fixes: e7895864b0d7 ("hwmon: (max6621) Add support for Maxim MAX6621 temperature sensor")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Vadim Pasternak <vadimp@mellanox.com>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
drivers/hwmon/max6621.c

index 22079ec29660ecb9752ac20e40247afecc136aa6..35555f0eefb96239d9d94cb5641c5f2abcef3255 100644 (file)
@@ -296,7 +296,7 @@ max6621_read(struct device *dev, enum hwmon_sensor_types type, u32 attr,
                        if (regval) {
                                ret = i2c_smbus_write_byte(data->client,
                                                MAX6621_CLEAR_ALERT_REG);
-                               if (!ret)
+                               if (ret)
                                        return ret;
                        }