tty: serial: bcm63xx: fix missing clk_put() in bcm63xx_uart
authorZou Wei <zou_wei@huawei.com>
Tue, 21 Apr 2020 12:31:46 +0000 (20:31 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 23 Apr 2020 13:48:53 +0000 (15:48 +0200)
This patch fixes below error reported by coccicheck

drivers/tty/serial/bcm63xx_uart.c:848:2-8: ERROR: missing clk_put;
clk_get on line 842 and execution via conditional on line 846

Fixes: ab4382d27412 ("tty: move drivers/serial/ to drivers/tty/serial/")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zou Wei <zou_wei@huawei.com>
Cc: stable <stable@vger.kernel.org>
Link: https://lore.kernel.org/r/1587472306-105155-1-git-send-email-zou_wei@huawei.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/serial/bcm63xx_uart.c

index 5674da2b76f0f23b4681f181aed82aab347abc98..ed0aa5c0d9b79829f26e501bab29a033369534e0 100644 (file)
@@ -843,8 +843,10 @@ static int bcm_uart_probe(struct platform_device *pdev)
        if (IS_ERR(clk) && pdev->dev.of_node)
                clk = of_clk_get(pdev->dev.of_node, 0);
 
-       if (IS_ERR(clk))
+       if (IS_ERR(clk)) {
+               clk_put(clk);
                return -ENODEV;
+       }
 
        port->iotype = UPIO_MEM;
        port->irq = res_irq->start;